This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Feature: Add ability to define declare statements #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to configure declare() statements at the top of generated files. It is only possible to generate valid declare statements as stated in php documentation https://www.php.net/manual/en/control-structures.declare.php Solves #102
|
@icanhazstring I would go with |
|
@icanhazstring maybe I missed something but with that implementation is not possible to add declare like: declare(strict_types=1,ticks=1);but it's valid. It can have even all three declarations - |
|
@icanhazstring |
|
@webimpress wanted to write this. Yes ;) |
added 2 commits
June 17, 2019 11:28
GaryJones
suggested changes
Jun 17, 2019
added 2 commits
June 17, 2019 17:32
michalbundyra
added a commit
that referenced
this pull request
Oct 5, 2019
Feature: Add ability to define declare statements
michalbundyra
added a commit
that referenced
this pull request
Oct 5, 2019
michalbundyra
added a commit
that referenced
this pull request
Oct 5, 2019
|
Thanks, @icanhazstring! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the ability to configure declare() statements
at the top of generated files.
I took the implementation suggestion from @GaryJones in #102 and changes it a bit.
I changed the behavior to be only able to generate valid
declarestatements at all.Also I added static factories to generate the possible directives.
Should solve #102
One problem tho. SinceRenamed todeclareis a reserved keyword. The I decided to go withDeclare_as the class representation. But the codesniffer doesn't like this. Any suggestions?DeclareStatementas suggested by @webimpress